fix bug on update_package.py

Update comments on update_package.py

add comments that help understand the issue that the latest sclauncher doesn't get updated. The version from the regex (current version) didn't include `v` however the function get_latest_version did include the `v`. The URL replaced the version without `v` (current version) with the latest version found that included the `v`, which resulted in the wrong URL `https://github.com/jstrosch/sclauncher/releases/download/vv0.0.6/sclauncher.exe`

scripts/utils/update_package.py

@@ -37,7 +37,10 @@ def get_latest_version(org, project, version):
         print(f"GitHub API response not ok: {response.status_code}")
         return None
     latest_version = response.json()["tag_name"]
-    return latest_version
+    if latest_version.startswith('v'):
+    	return latest_version.replace('v','',1)
+    else:
+    	return latest_version
 
 
 # Get url response's content hash (SHA256)
@@ -104,6 +107,7 @@ def update_github_url(package):
 
     latest_version = None
     for url, org, project, version in matches:
+        # version excludes `v` from the capturing group in the regex therefore latest_version_match mustn't include `v` if the version starts with `v`
         latest_version_match = get_latest_version(org, project, version)
         # No newer version available
         if (not latest_version_match) or (latest_version_match == version):