Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manabie test PR - Nguyen Hoang Linh #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhlinhhci
Copy link

@nhlinhhci nhlinhhci commented May 15, 2022

My name is Nguyen Hoang Linh, this is my submitted PR for the Manabie Coding Challenge.
Upcoming changes according to this PR:

  1. Fix some bugs:
  • Fixed some bugs on create todo and delete todo function, and some minor ones throughout the project.
  • Comments has been added for closer comparison before-after fix.
  1. Enhance UI/UX:
  • UI:
    • Re-styled buttons, inputs, text when active/completed, checkboxes, etc.
    • Adding hovering effects, cursors, transitions throughout the application where I feel needed for smoother experience.
    • Remove/replace some unneccessary buttons.
    • Added Dark mode.
    • Adding ellipsis for long text, hovering will show the full text.
  • UX:
    • Remove text after submit the task, adding autofocus.
    • Validation if the input is blank. (cannot submit and shows error, both when create todo and edit todo)
  1. Edit mode:
  • Double click will show input at that task position for editting (also checks for blank input). Hit 'Enter' to submit edited task, Hit 'Escape' or click outside the input will close it as well.
  1. Save in localStorage:
  • Todos and user's theme choice (added Dark Mode feature) has been save to localStorage so the user can easily refresh and return to their todo-list everytime they feel needed.
  1. All Active/All Completed button:
  • Make them work. 'All Active' will make all tasks 'ACTIVE', same for 'All Completed', will make them 'COMPLETED'.
  1. Remove redundancies:
  • Refactor and remove some unneccessary codes.

Please feel free to comment for improvements.
Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant