Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Font-end] manabie-challenge - Dang Van Quoc Phong #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phongdang707
Copy link

@phongdang707 phongdang707 commented May 10, 2022

Fix Bug

  • Create duplicate task
  • Crash app when check item todo
  • Action for "All" , "Active", "Completed" are not working properly
  • Button remove item todo and check all item are not working

Add feature

  • Struct follow react-boilerplate-cra
  • Build struct component follow ATOMIC design
  • Add status important
  • Use localStorage for mock API: get, create, update, remove and update status todo
  • Delete todo item
  • Delete all todo
  • Filter by All, Active, Completed, Important
  • On click checkbox to change status Completed or Active
  • On click status important
  • Filter status important
  • Edit content todo
  • Add test component

Do not

  • Unit test for module
  • Integration test

Need more development

  • Using ESlint vs Prettier for synchronized style code team member and format code
  • Add hook useFetchData for call API
  • Validate content empty item todo when create update
  • Add package style-component for organization and management CSS
  • Apply tailwind css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant