Test meaningful error message when reading incompletes from non-existent symbol #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasil-pashov
approved these changes
Nov 7, 2024
poodlewars
reviewed
Nov 7, 2024
|
|
||
|
|
||
| @pytest.mark.parametrize("batch", (True, False)) | ||
| def test_read_incompletes_non_existant_symbol(lmdb_version_store_v1, batch): |
poodlewars
reviewed
Nov 7, 2024
| @pytest.mark.parametrize("batch", (True, False)) | ||
| def test_read_incompletes_non_existant_symbol(lmdb_version_store_v1, batch): | ||
| lib = lmdb_version_store_v1 | ||
| sym = "test_read_incompletes_non_existant_symbol" |
alexowens90
changed the title
poodlewars
approved these changes
Nov 7, 2024
alexowens90
deleted the
bugfix/arcticdb-ursus/8/test-meaningful-error-when-reading-incompletes-from-non-existant-symbol
branch
grusev
pushed a commit
that referenced
this pull request
Nov 25, 2024
…ent symbol (#1991) #### Reference Issues/PRs Closes man-group/arcticdb-ursus#8 #### What does this implement or fix? Actual bug was fixed, probably in #1950, this just adds a test of the correct behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes https://github.com/man-group/arcticdb-ursus/issues/8
What does this implement or fix?
Actual bug was fixed, probably in #1950, this just adds a test of the correct behaviour