Merge pull request #2 from mamitech/develop

error visibility during exec command
mamitech · May 6, 2024 · 859f72d · 859f72d
2 parents efae449 + 2b6decf
commit 859f72d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/Events/BaseEvent.php b/src/Events/BaseEvent.php
@@ -10,7 +10,7 @@ class BaseEvent
     use InteractsWithSockets;
     use Dispatchable;
 
-    public function __construct(public string $action, public string $command)
+    public function __construct(public string $action, public string $command, public bool $isSuccess = true)
     {
     }
 }
diff --git a/src/Events/ExecCommandEvent.php b/src/Events/ExecCommandEvent.php
@@ -4,8 +4,8 @@
 
 class ExecCommandEvent extends BaseEvent
 {
-    public function __construct(string $command)
+    public function __construct(string $command, bool $isSuccess)
     {
-        parent::__construct('exec_command', $command);
+        parent::__construct('exec_command', $command, $isSuccess);
     }
 }
diff --git a/src/Http/Controllers/DashboardController.php b/src/Http/Controllers/DashboardController.php
@@ -2,6 +2,7 @@
 
 namespace Acdphp\SchedulePolice\Http\Controllers;
 
+use Acdphp\SchedulePolice\Data\ExecResult;
 use Acdphp\SchedulePolice\Events\ExecCommandEvent;
 use Acdphp\SchedulePolice\Events\StartScheduleEvent;
 use Acdphp\SchedulePolice\Events\StopScheduleEvent;
@@ -62,7 +63,7 @@ public function exec(ExecRequest $request): RedirectResponse
         $command = $request->validated('command');
         $output = $this->service->execCommand($command);
 
-        ExecCommandEvent::dispatch($command);
+        ExecCommandEvent::dispatch($command, !$output->isError);
 
         return Redirect::route('schedule-police.index')
             ->withFragment('#v-execute')