feat: add support for conditional dependencies #101
+404
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Jan 18, 2025
src/solver/clause.rs
Outdated
| ) -> (Self, Option<[Literal; 2]>, bool) { | ||
| // It only makes sense to introduce a conditional clause when the package is undecided or going to be installed | ||
| assert_ne!(decision_tracker.assigned_value(package_id), Some(false)); | ||
| assert_ne!(decision_tracker.assigned_value(condition), Some(false)); |
There was a problem hiding this comment.
The condition might already have any value assigned.
src/solver/clause.rs
Outdated
| package_id: VariableId, | ||
| condition: VariableId, | ||
| then: Requirement, | ||
| candidates: impl IntoIterator<Item = VariableId>, |
There was a problem hiding this comment.
Its unclear which candidates these are? Is it for the condition, the requirement or the combined set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.