fix: Use CA certificates from conda-forge::ca-certificates
#3765
Conversation
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
changed the title
conda-forge::ca-certificates
jjerphan
force-pushed
the
fix/ca-certificate-resolution
branch
from
1726bc9 to
1b17459
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/ca-certificate-resolution
branch
3 times, most recently
from
0df8b27 to
bcb9d08
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/ca-certificate-resolution
branch
from
bcb9d08 to
7205e24
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/ca-certificate-resolution
branch
from
bd29417 to
c35ccd0
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/ca-certificate-resolution
branch
from
c35ccd0 to
66d72d9
Compare
There was a problem hiding this comment.
LGTM despite my doubts about the Context root_prefix member. Maybe @Klaim has
a better understanding of the initialization of these variables.
| @@ -177,7 +178,7 @@ namespace mamba | |||
| Context::Context(const ContextOptions& options) | |||
| { | |||
| on_ci = static_cast<bool>(util::get_env("CI")); | |||
| prefix_params.root_prefix = util::get_env("MAMBA_ROOT_PREFIX").value_or(""); | |||
| prefix_params.root_prefix = detail::get_root_prefix(); | |||
There was a problem hiding this comment.
That's the only part I'm not sure about, since prefix_params.root_prefix is used to store the root_prefix set by the config (see https://github.com/mamba-org/mamba/blob/main/libmamba/src/api/configuration.cpp#L1237-L1245). I don't know whether some parts of the code do something specific when this variable is empty, nor if there are use cases where it would be valid to have it empty (when using the library out of mamba / micromamba for instance).
I dont think I have more understanding here, although I share your suspicion. A cursory look at how that variable is used suggests to me that most of libmamba's code relies on this variable to not be empty. |
See conda-forge/miniforge#715 (comment).