maint: Ignore formatting changes in history

[mathbunnyru]

No description provided.

[mathbunnyru]

Not allowing to both change style and something meaningful in the same PR is definitely up to reviewers.

[jjerphan]

LGTM modulo a title change to something like "maint: Ignore formatting changes in history" since this ignores more than those two files.

[mathbunnyru]

@jjerphan I rebased the changes, and added prettier entry as well.

[Hind-M]

Thank you for handling this!

[Hind-M]

Suggested change

	# bump clang-format to 13.0.1 and make it work again
	# bump clang-format to 13.0.1 and make it work again (PR number)

Can we add the PR number like in the others? (some numbers are missing here and there below).

[mathbunnyru]

There was no PR: 7f9c5ad
https://github.com/search?q=repo%3Amamba-org%2Fmamba+bump+clang-format+to+13.0.1&type=pullrequests

[mathbunnyru]

And I don't want to manually add PR numbers to other places - I don't see a lot of sense, and it will be more difficult to update this file later (more manual changes - less clear it is).

[Hind-M]

I agree that we shouldn't do this manually, but I'm wondering why it was added automatically in some and not others? Was it because they were all not PRs?

[mathbunnyru]

Some of them were PRs.

Until 2022-10-26, some PRs were not squashed when merged to the main branch.
If you squash merge, GitHub automatically adds a PR number to the commit message.
If you don't, then you get the original commit and the original commit message (so there will be no PR number).

You can notice, that the lines without PR numbers are always at the bottom of the lists, so we won't have such a problem in the future (unless someone forgets to squash when merging the PR).

[Hind-M]

This seems to be more than formatting, so should be commented?

[mathbunnyru]

I think it is 99.9% formatting: 50a627e
Moreover, this commit has been ignored for several years:

mamba/.git-blame-ignore-revs

Line 5 in d0c7458

50a627e002d8260fa2e116e5833190a135aff4e8

(Don't look at the wrong commit message in main, but exactly this commit hash is already ignored in main).

[Hind-M]

Thanks!

[mathbunnyru]

@Hind-M @JohanMabille @jjerphan I forgot to tell you — prettier has been merged to main today, and I highly recommend you merge main in all the current PRs touching at least one non-python or non-cpp file.
Otherwise, there is a chance these PRs have the wrong styling and you will have to fix main after merging these PRs.

And to make it even better, I would also recommend adding https://pre-commit.ci as an app:

• it runs faster
• applies autofixes in PRs (when tools have autofixes).
• you can auto-update hooks, which is quite nice

We've been using it for years across several jupyter projects - it works really well.
I can start an issue for that, but I won't be able to add this tool myself - you need org-level permissions to do that.

Updated: an issue: #3741