Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install using explicit url #3710

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Dec 24, 2024

Fix #3304

@Hind-M Hind-M added the release::bug_fixes For PRs fixing bugs label Dec 24, 2024
@Hind-M Hind-M marked this pull request as ready for review December 26, 2024 14:58
@Hind-M Hind-M mentioned this pull request Dec 26, 2024
3 tasks
@hvenev-insait
Copy link

hvenev-insait commented Dec 26, 2024

Commit ac3c921 looks very suspicious to me. Assuming util::contains is roughly strstr, won't this match lots of package URLs simply because the path/channel/target/name/version/build happens to contain ghcr?

@Hind-M
Copy link
Member Author

Hind-M commented Dec 27, 2024

Commit ac3c921 looks very suspicious to me. Assuming util::contains is roughly strstr, won't this match lots of package URLs simply because the path/channel/target/name/version/build happens to contain ghcr?

Yes, but that should be unlikely. I changed the condition though to something more robust.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Hind-M.

libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
@Hind-M Hind-M merged commit 9dd3999 into mamba-org:main Jan 6, 2025
34 checks passed
@Hind-M Hind-M deleted the install_from_url branch January 6, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install package by URL
4 participants