Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve CUDA version detection #3700

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: Improve CUDA version detection #3700

merged 2 commits into from
Jan 6, 2025

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Dec 18, 2024 •
edited
Loading

No description provided.

@jjerphan
fix: Improve CUDA version detection
4b79b1e 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Dec 18, 2024
@jjerphan jjerphan marked this pull request as ready for review December 18, 2024 16:30
Klaim
Klaim approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than avoiding searching 3 times, LGTM

libmamba/src/core/virtual_packages.cpp Outdated Show resolved Hide resolved
@jjerphan @Klaim
Only search once in JSON
068e74d 
Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Klaim <[email protected]>
@jjerphan jjerphan merged commit 4f97739 into mamba-org:main Jan 6, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjerphan @Klaim