-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
micromamba/mamba --version
displays pre-release version names + establishes pre-release versions name scheme
#3639
Conversation
d130b82
to
b618cb7
Compare
Note that this version accepts a minimum of 3 dot-separated fields but does not limit the number of dots over 3, so schemes with and without additional dots are considered "valid" by the validation script. |
version_scheme.py
Outdated
) | ||
) | ||
|
||
VALID_VERSION_PRERELEASE_TYPES = ("alpha", "beta") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about rc
and dev
?
Adding this as a reference. |
This piece of |
08aa760
to
75c1a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not include the changes so that umamba --version
shows pre-release versions, right?
It does (if it doesnt, its a bug in this pr): In the previous code, the version name was parsed, the major minor and patch number were extracted, then the version string define was re-built from that. In this PR we just print the validated name that was used, so it will be whatever you passed to the script as long as it has been validated. Note that it's not visible in this PR because I didnt use a pre-release version, but if you want I can use it with |
…d and make that field visible in `--version`
f370833
to
d1a81f8
Compare
For clarity and because it's one of the intended usage, I added a commit that sets the version to |
I just realized that the cmake scripts are taking the version name from the major.minor.patch numbers only, so cmake believes this is 2.0.5. @JohanMabille @jjerphan Should I fix that in this PR or another one? |
@JohanMabille Confirmed that version name is complete in |
Yeah my bad, I misread the code. |
I think it can be done in a dedicated PR |
Note that I've re-launched already 3 times the failing CI run with the vcpkg command (which failed so far when trying to acquire a package); not sure what's going on exactly. |
This was a vcpkg issue, not related to mamba. |
Part of the effort for #3638
While I started this just to allow displaying the pre-release versions in
micromamba/mamba --version
, this required also changing the release scripts to provide the relevant information to the source code. As part of that change I setup the discussed pre-release version naming scheme with validation in the release scripts.Also deprecates
mamba::version_arr()
andumamba::version_arr()
functions which seem unusued. If there is a need for information about the version, I'll add another more precise function as a replacement, or we'll just remove these.