Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Ruff #3011

Merged
merged 21 commits into from
Nov 27, 2023
Merged

Move to Ruff #3011

merged 21 commits into from
Nov 27, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Nov 27, 2023

Tired of modifying X files to configure Y tools.

@jonashaag
Copy link
Contributor

Cool! I guess pre-commit should also be updated?

@AntoinePrv
Copy link
Member Author

Working on fixing many warnings

@AntoinePrv AntoinePrv requested a review from jonashaag November 27, 2023 15:28

[tool.ruff]
line-length = 88
target-version = "py37"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting [project].requires-python instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it honored by ruff? I'd rather keep it in the ruff section since this top level pyproject.toml does not correspond to any project, but rather is used to configure dev tools (bit confusing...),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yes it is

@AntoinePrv AntoinePrv merged commit 1230b92 into mamba-org:main Nov 27, 2023
27 checks passed
@AntoinePrv AntoinePrv deleted the ruff branch November 27, 2023 18:10
@JohanMabille
Copy link
Member

modifying X files

x-files-paranormal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants