Simplify and correct development documention #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Nov 13, 2023
AntoinePrv
commented
- Use a single file for contributing guidelines
- Add doc builds to taskfile
- Fix sphinx warnings
- Simplify development doc
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
Co-authored-by: Johan Mabille <[email protected]>
|
@dholth if that can be useful to you. |
JohanMabille
approved these changes
Nov 14, 2023
|
Documentation only, no need to wait for the CI. |
dholth
reviewed
Nov 14, 2023
|
|
||
| When contributing to this repository, it is always a good idea to first | ||
| discuss the change you wish to make via issue, email, or any other method with | ||
| the owners of this repository before making a change. | ||
|
|
||
| We welcome all kinds of contribution -- code or non-code -- and value them | ||
| highly. We pledge to treat everyone's contribution fairly and with respect and | ||
| highly. We pledge to treat everyones contribution fairly and with respect and |
There was a problem hiding this comment.
Suggested change
| highly. We pledge to treat everyones contribution fairly and with respect and | |
| highly. We pledge to treat everyone's contribution fairly and with respect and |
The original is correct.
dholth
reviewed
Nov 14, 2023
dholth
reviewed
Nov 14, 2023
| -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \ | ||
| -DCMAKE_PREFIX_PATH=$CONDA_PREFIX \ | ||
| -DBUILD_MICROMAMBA=ON | ||
| cmake --build build/ |
There was a problem hiding this comment.
these instructions were not that bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.