Channel initialization #2953
Merged
Channel initialization #2953
+839
−672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Oct 31, 2023
AntoinePrv
commented
- Set default_channels at config level
- Resolve default multi channel at the config level
- Fix Yaml source printers
- Resolve local multi channel at the config level
- Remove ChannelContext::make_simple_channel
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
8 times, most recently
from
f06f5e9 to
e47f8c2
Compare
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
5 times, most recently
from
ddaa356 to
1b8f371
Compare
| specs::CondaURL url, | ||
| std::string canonical_name, | ||
| util::flat_set<std::string> platforms = {} | ||
| ); |
There was a problem hiding this comment.
Now that this constructor is public, do we still need the make_channel method in the ChannelContext?
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
from
044f463 to
c7a93a1
Compare
JohanMabille
approved these changes
Nov 15, 2023
|
Let's merge this one and iterate, to ease the review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.