Fix Linux version regex

[kelszo]

Closes #1851

Current PR fixes an incorrect regex for detecting Linux kernel versions leading to not being able to create a Linux virtual package on certain distros.

[jonashaag]

Thanks for the patch. Can you add a test?

[kelszo]

Shouldn't the patch be covered by the test_virtual_packages.cpp tests already? Or do you want more specific tests?

[jonashaag]

Shouldn't the patch be covered by the test_virtual_packages.cpp tests already? Or do you want more specific tests?

If we had a test for this change then CI would’ve been red before, but it was green, or do I miss something?

[kelszo]

The reason why the tests didn't fail before was because in the CI they seem to run on Ubuntu. Ubuntu's kernel versions include the flavour tag. See #1851 for more information.

The tests failed first locally on my machine (NixOS) so I guess running the tests on such a distro would cover this patch.

[jonashaag]

Thanks, that makes sense. I guess it’s not worth adding another distro to the CI setup but we could add a unit test for the code that matches the regex and supply a hardcoded name in the test.

[jonashaag]

It would require that we refactor the code a little bit though because as it is it’s not testable unless we override the uname program