This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Update for conda/conda-build deprecations #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
update-for-conda-build-deprecations
branch
4 times, most recently
from
76ebc17 to
d6eae80
Compare
conda._vendor.boltons has been marked for deprecation in conda=23.3 and will be removed in conda=23.4. refs: - https://github.com/conda/conda/pull/12453/files Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
update-for-conda-build-deprecations
branch
from
95fd1b8 to
b6572ec
Compare
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
update-for-conda-build-deprecations
branch
2 times, most recently
from
8e23ad8 to
689bf8e
Compare
Signed-off-by: Marcel Bargull <[email protected]>
refs: - conda/conda-build#5222 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L15 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L95 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L104 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L114 - https://github.com/conda/conda/blob/24.1.2/conda/utils.py#L235 Signed-off-by: Marcel Bargull <[email protected]>
ref: - conda/conda-build#5184 Signed-off-by: Marcel Bargull <[email protected]>
Fixes mamba-org#388 Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
update-for-conda-build-deprecations
branch
from
689bf8e to
1aa8d1f
Compare
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
commented
Mar 16, 2024
| @@ -149,7 +149,7 @@ def get_value(self, in_key: str, default: Any = None, autotype=True) -> Any: | |||
| if autotype and default is None and FIELDS.get(section, {}).get(key): | |||
| default = FIELDS[section][key]() | |||
|
|
|||
| section = self.output.sections.get(section, {}) | |||
| section = self.meta.get(section, {}) | |||
There was a problem hiding this comment.
This caused gh-388 since .get_value is called from conda-build code which expects return types from original conda_build.metadata.MetaData (e.g., str, not CondaBuildSpec).
From a quick glance, I couldn't make out any calls from within boa that expect boa-specific types here; would be good to have another pair of eyes confirming this..
This was referenced Mar 16, 2024
|
cc @SylvainCorlay (for awareness) |
|
Terrific job, thanks! |
|
Nice. Thank you @mbargull |
|
Thanks all! 🙏 Think we will want a release with these changes as well. Not sure what the process is there |
|
Just made a PR @jakirkham #396 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
boafor compatibility with current/upcomingconda-buildversions.Overview:
conda/conda-buildpre-release versions.boltonsdependency sinceconda._vendor.boltonsis being removed.conda-buildto3.25(semi-arbitrarily chosen;>=3.25include, e.g., fixes for downstream tests).conda_build.conda_interface.