fix rounding errors in responsive carousel #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clipping the edge of a crucial slide in a responsive carousel looks really bad. This currently happens way too easily. Two fixes: 1) Browsers don't seem to resolve all rounding-related layout issues until load. Listen for that as well as resize. 2) Don't round slide dimension up to the nearest integer. This causes overflow. All modern browsers have used subpixel rendering for a while now. See column 4 in this chart: http://cruft.io/posts/percentage-calculations-in-ie/
| @@ -143,7 +143,7 @@ $.fn.cycle.transitions.carousel = { | |||
| var prepareDimensions = this.prepareDimensions; | |||
|
|
|||
| // throttle resize event | |||
| $(window).on( 'resize', resizeThrottle); | |||
| $(window).on( 'load resize', resizeThrottle); | |||
|
|
|||
| opts._carouselResizeThrottle = resizeThrottle; | |||
| onResize(); | |||
There was a problem hiding this comment.
This should be removed to prevent onResize from being called twice. It will be called on window.load so we no longer need it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clipping the edge of a crucial slide in a responsive carousel looks really bad. This currently happens way too easily. Two fixes:
Browsers (incl Chrome) don't seem to resolve all rounding-related layout issues until load. Listen for that as well as resize.
Don't round slide CSS widths up to the nearest integer. This causes the last visible slide in the carousel to overflow the container. All modern browsers have used subpixel rendering for a while now. See column 4 in this chart:
http://cruft.io/posts/percentage-calculations-in-ie/