Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvements and Addition of New Features #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adriel007
Copy link

Changes Documentation

1. Signal Handling Addition

  • Added a signal handler to capture the SIGINT signal (Ctrl+C) and cancel the email search if the user wishes to interrupt it.

2. clean_html_tags Method in myparser Class

  • The genericClean method was replaced by the clean_html_tags method in the myparser class. This was done to make the naming more descriptive and cohesive with the method's responsibility.

3. clean_special_characters Method in myparser Class

  • A new method called clean_special_characters was added to the myparser class. It is responsible for cleaning special characters from the results string, replacing them with whitespace.

4. Regex Change in emails Method of myparser Class

  • The regex in the emails method was modified to use "raw" strings (prefixed with r) to improve readability and avoid issues with backslashes in escape characters.

5. Exception Handling Addition in __init__ Method of EmailHarvester Class

  • Exception handling was added for plugin import and initialization. This ensures that any errors during these processes are captured and handled appropriately.

6. Redundant Exception Handling Removal

  • Some blocks of code containing redundant exception handling were removed. For example, the try-except block around the call to r.raise_for_status() in the do_search method of the EmailHarvester class was removed, as requests.get already raises a requests.exceptions.HTTPError exception if the response has an error status.

@chvollm
Copy link

chvollm commented Oct 13, 2024

@Adriel007 Great! Thanks for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants