gdcmcharls fix nullptr dereferece #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This cannot be merged into GDCM without checking upstream first. Upstream is : https://github.com/team-charls/charls
|
|
In fact the CharLS in GDCM is rather old. Would be interesting to see if the newest CharLS works if copied into GDCM... |
|
@seanm, as you already said, the used CharLS sources are rather old. I had tried, but did not find the file I changed in an up-to-date version. I believe it is good to have this fix, unless CharLS is not updated. |
|
It would be better, but of course more work, to update CharLS in GDCM. I'm not sure how backwards-compatible CharLS is generally, if we are lucky GDCM won't even need changes, and it could be a drop-in replacement... feel like trying? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that it is external copypasta code. But GCC12 compile rises -Werror=nonnull warning and it makes sense.
According to an exception message, the exception must be thrown if params.thumbnail is nullptr. Moreover, right now the pointer remains nullptr and it is dereferenced in the very next statment. So, I am tent to believe the current version is mistaken and should be fixed.