ByteValue: safer and more effitient memory usage #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, these change rid of some -Werror=nonnull warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, the user can initialize a ByteValue object with nullptr and non-zero length which may lead to nullprt dereference.
Secondly, if the passed length is odd, already initialized "Internal" vector is resized, which most likely causes memory reallocation and copy. Instead, memory can be allocated only once after a proper length calculated. On top of that, "memcpy" might be faster than than initializing with "Internal(array, array+vlm)". It safe as Internal is just a vector of chars.
To sum up, taking into consideration that ByteValue is oftenly used, I believe these changes are worth to be taken.