Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeinforge bug fixes #295

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Skeinforge bug fixes #295

wants to merge 48 commits into from

Conversation

rparkins999
Copy link

This is a collection of patches to Skeinforge to fix bugs I encountered while using ReplicatorG since I orginally installed it some time ago. Three of them prevent divisions by zero, and the other fixes a typo which prevented the replace option in export.py from working properly.

@rparkins999
Copy link
Author

Sorry I added another commit before I realised that I hadn't closed the pull request. This change adds a function to insert trace comments into the generated gcode. I find it more useful than python print statements because I get the gcode context. Others may of course disagree.

@rparkins999 rparkins999 reopened this Mar 22, 2015
@rparkins999
Copy link
Author

I wasn't familiar with the protocol here. I thought I had to close the request before I could be merged.

The default (5.0) is sensible, but the calculated value can be silly on some configurations (0.045 on my machine). The user needs to be able to set it to a large number for dual extrusion.
This is in preparation for modifying the Dual Extrusion merge logic so that it does not override the user's preferences with its own fixed defaults. The user must be able to specify (at least) that the <layer> and </layer> comments used by the Dual extrusion merge are not removed, even if other comments should be deleted.
Use corrected local help page
Add note that Object First Layer Perimeter Temperature currently doesn't work
 (making both first layer infill and perimeter temperatures work is harder)
	make it use the user's start.gcode and end.gcode instead of it own and make it work if the two extruders should run at different temperatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant