-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeinforge bug fixes #295
Open
rparkins999
wants to merge
48
commits into
makerbot:master
Choose a base branch
from
rparkins999:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Skeinforge bug fixes #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry I added another commit before I realised that I hadn't closed the pull request. This change adds a function to insert trace comments into the generated gcode. I find it more useful than python print statements because I get the gcode context. Others may of course disagree. |
I wasn't familiar with the protocol here. I thought I had to close the request before I could be merged. |
The default (5.0) is sensible, but the calculated value can be silly on some configurations (0.045 on my machine). The user needs to be able to set it to a large number for dual extrusion.
This is in preparation for modifying the Dual Extrusion merge logic so that it does not override the user's preferences with its own fixed defaults. The user must be able to specify (at least) that the <layer> and </layer> comments used by the Dual extrusion merge are not removed, even if other comments should be deleted.
Use corrected local help page Add note that Object First Layer Perimeter Temperature currently doesn't work
… manager to set its position.
(making both first layer infill and perimeter temperatures work is harder)
make it use the user's start.gcode and end.gcode instead of it own and make it work if the two extruders should run at different temperatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of patches to Skeinforge to fix bugs I encountered while using ReplicatorG since I orginally installed it some time ago. Three of them prevent divisions by zero, and the other fixes a typo which prevented the replace option in export.py from working properly.