Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-2258: introduces maistra.io/xns-informer redirect #183

Open
wants to merge 1 commit into
base: maistra-2.1
Choose a base branch
from

Conversation

bartoszmajsak
Copy link
Contributor

This is for go modules to have consistent way of dealing with our dependencies (as we already do with maistra/api)

go get maistra.io/xns-informer

@maistra-bot
Copy link

@bartoszmajsak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
maistra.github.io_lint-2.1 dfed497 link true /test lint
maistra.github.io_check-links-2.1 dfed497 link true /test check-links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo is unmaintained, so, if the jobs are blockers, I'd just merge it manually.

also, I'm not sure if this will work out of the box. If not, we'd need to ping the maintainer (rob?) to take some action.

@jwendell
Copy link
Member

if you want to merge this manually: reduce the approvers number to 1; remove the required jobs

@bartoszmajsak
Copy link
Contributor Author

@jwendell I noticed it's rusty. Maybe it's time to revamp this place then?

@jwendell
Copy link
Member

I wouldn't waste time on this repo unless PM says so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants