[WIP]OSSM-5881 Do not require ingress and egress gateways when spec.cluster.multiCluster is enabled
#1643
Conversation
mayleighnmyers
force-pushed
the
OSSM-5881
branch
from
8f38d57
to
c3e6010
Compare
mayleighnmyers
force-pushed
the
OSSM-5881
branch
from
838ae2b
to
5418648
Compare
There was a problem hiding this comment.
Changed valmap to val since there was a tautological condition.
|
/test unit |
1 similar comment
|
/test unit |
| gateways: | ||
| enabled: false | ||
| useILB: false | ||
| `), |
There was a problem hiding this comment.
These values are obviously incorrect, so this test fails as expected.
There was a problem hiding this comment.
When I run the test locally it is asking me to add a bunch of stuff, should I keep it to what you had put into the jira?
There was a problem hiding this comment.
When I run the test locally it is asking me to add a bunch of stuff
You should never adjust expected test data to the actual result just to make the test pass. Your test and data should drive the implementation, so first fix the expected helm values and the input (SMCP spec) and then work on the implementation until it passes for the correct input and output.
should I keep it to what you had put into the jira?
In JIRA I added only SMCP spec. You can use that YAML to properly configure input SMCP in your test.
| Security: &v2.SecurityConfig{ | ||
| CertificateAuthority: &v2.CertificateAuthorityConfig{ | ||
| Type: v2.CertificateAuthorityTypeCertManager, | ||
| CertManager: &v2.CertManagerCertificateAuthorityConfig{ | ||
| Address: "", |
There was a problem hiding this comment.
It's a good direction, but I can see that many tests fail, including the new one:
--- FAIL: TestMultiClusterGatewaysDisabled (0.00s)
--- FAIL: TestMultiClusterGatewaysDisabled/MultiCluster_v2_4-v2_to_v1 (0.00s)
--- FAIL: TestMultiClusterGatewaysDisabled/MultiCluster_v2_4-v1_to_v2 (0.00s)
Can you fix these tests?
There was a problem hiding this comment.
You modified cluster.go, so I would expect to see appropriate tests in cluster_test.go.
|
@mayleighnmyers: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OSSM-5881
Currently, users cannot disable ingress and egress gateways when multi-cluster is enabled, because setting spec.gateways.enabled is ignored when spec.cluster.multiCluster is enabled.
Acceptance criteria:
When the SMCP above is applied, ingress and egress gateways are not deployed.