Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Borg Backup even when backing up mysql #700

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

wb7
Copy link
Contributor

@wb7 wb7 commented Apr 18, 2024

Hello,

regarding this forum thread: https://community.mailcow.email/d/1796-borgmatic-does-not-backup-vmail/ Borgmatic isn't backing up everything when also dumping the database using a hook because of the one_file_system: true setting.

Adding the mounted volumes explicitly to the list solves this issue.

@MAGICCC
Copy link
Member

MAGICCC commented Apr 25, 2024

So we can merge this safely?

@mrclschstr
Copy link

Yes, I think that's a reasonable workaround for the moment.

Maybe a small improvement: I'm pretty sure that the path /mnt/source in the borgmatic configuration under source_directories is no longer needed. Maybe @wb7 could confirm this briefly?

@wb7
Copy link
Contributor Author

wb7 commented Apr 25, 2024

I checked the suggestion of @mrclschstr and can confirm this; /mnt/source could be removed.

@MAGICCC MAGICCC merged commit 6cfe5ef into mailcow:master Apr 25, 2024
@MAGICCC
Copy link
Member

MAGICCC commented Apr 25, 2024

ok thx

@witten
Copy link

witten commented Apr 25, 2024

LGTM!

@witten
Copy link

witten commented Nov 10, 2024

This should no longer be necessary, so it may be worth backing out or updating. Specifically, borgmatic 1.9.0+ no longer implicitly enables one_file_system when databases are configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants