Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: v12 support #17

Closed
wants to merge 44 commits into from
Closed

Feature: v12 support #17

wants to merge 44 commits into from

Conversation

maikschneider
Copy link
Owner

  • new JS build process with rollup.js
  • ES6 module

closes #1, #16

maikschneider and others added 18 commits March 8, 2023 00:28
@maikschneider
feat: install v12, rollup js to generate es6 and amd module
1bbd84d
@Jeggle-s
feat: replace es6 imports with amd imports
44561b0 
With es6 modules the namespaces for importing TYPO3 Packages are different than those for amd.

With this change during the build process those imports will be transformed so they are backwards compatible for older TYPO3 versions
@maikschneider
feat: install rollup sourcemap plugin, disable terser plugin
a9b0511
@maikschneider
fix: js inclusion for v11 (amd)
2bac21f
@maikschneider
fix: modal hide for v11 & v12
e026a59
@maikschneider
feat: add terser plugin only for build command
3efb11f
@maikschneider
chore: change npm watch to start command
73c463d
@maikschneider
chore: remove old webpack config files
695b034
@maikschneider
feat: set v12 support in ext_emconf.php
140170e
@maikschneider
fix: button markup and title translation
21c54d6
@maikschneider
Merge commit '140170efe94731fa5a0b57ce3f1fd0017b18d634' into 12.x-dev
9f3673d 
* commit '140170efe94731fa5a0b57ce3f1fd0017b18d634':
  feat: set v12 support in ext_emconf.php
  chore: remove old webpack config files
@Jeggle-s
feat: enable loading of typo3 sources
69dbc89 
TypeScript was not able to find TYPO3 modules. The configuration had to be extended, so TypeScript knows where to find all TYPO3 modules which can be included by the Extension in the backend.
Source: https://github.com/TYPO3/typo3/blob/main/Build/tsconfig.json
@maikschneider
Merge commit '69dbc89c390dd4cb9a3f686ff6499e9328b2d53e' into 12.x-dev
0df2fc4 
* commit '69dbc89c390dd4cb9a3f686ff6499e9328b2d53e':
  feat: enable loading of typo3 sources
@maikschneider
Merge commit 'eb1110a706ae6ae555b7e8ed9ead3f3b198ffc33' into 12.x-dev
d725e70 
* commit 'eb1110a706ae6ae555b7e8ed9ead3f3b198ffc33':
  fix: configure phpmd in composer.json
  chore: add baseline for php mess detector
  chore: format phpmd.xml
  feat: install php mess detector
  feat: fix some phpstan errors
  feat: add phpstan configuration
  chore: apply php-cs-fixer
  feat: configure php-cs-fixer
  chore: blank line
  chore: blank line
  chore: blank line
  chore: blank line
  chore: rename step
  fix: permissions of phenx-php-font-lib.phar
  chore: rename step name
  fix: typo in workflow parameter
  feat: add reusable workflow for static code analysis

# Conflicts:
#	composer.lock
#	ext_emconf.php
@maikschneider
feat: install @ckeditor dependencies, add new IconPicker ts for ckedi…
83ab898 
…tor v5
@maikschneider
feat: add github codespace config
e323a30
@maikschneider
chore: update ddev config
ddc9f74
@maikschneider
feat: add settings.php for v12, use "/" as base in site config
1bc7715
@maikschneider
Copy link
Owner Author

maikschneider commented Apr 11, 2023 •
edited
Loading

ToDos:

  • CKEditor 5 Support (create and insert new icon element after close of IconPicker)

@typoworx-de
Copy link

Any progress here? Who can review and merge?

@maikschneider
Copy link
Owner Author

Hey,
I still have trouble making the RTE button woking again. The new CKEditor5 makes it really hard to insert image HTML. I'll do my best to release a new version soon. If you're not dependant on the RTE stuff, you can already use the 12.x-dev branch.
Best,
Maik

maikschneider and others added 17 commits October 6, 2023 15:26
@maikschneider
fix: add type check for HelperUtility constructor in form element
0a15ab0
@maikschneider
chore: code style, composer update
7e4376d
@maikschneider
feat: decode current pid of RTE from typo3link routeUrl configuration
8638f83
@maikschneider
feat: install testing-framework
6149009
@maikschneider
feat: configure phpunit
ed225ee
@maikschneider
fix: phpfixer
e945591
@maikschneider
Merge pull request #35 from maikschneider/feature/phpunit
a77c5b3 
Install PHPUnit
@maikschneider
feat: drop support for TYPO3 <12.0, require php8.0
f331812
@maikschneider
feat(WIP): refactor CssIconProvider (resolves #36)
06be459
@maikschneider
feat: import only used font files, evaluate css variables, check pref…
52d6cec 
…ix class for font weight + family (closes #37)
@maikschneider
feat: code style
7d8b2e4
@maikschneider
chore: code style
422ec11
@maikschneider
fix: disable language service in helper utility, fix ckeditor js imports
43e196a
@maikschneider
fix: es6 import paths, remove amd output, remove old RTE configuratio…
5e71acb 
…ns, remove old RTE plugin
@maikschneider
feat: extend RTE editor for typo3fonticon that converts into i tag
ac1c52e
@moritz-ngo
feat: add fileExtensionList option to FileIconProvider
116f411
@maikschneider
Merge pull request #43 from kandoh-gmbh/12.x-dev
d02b7b6 
feat: add fileExtensionList option to FileIconProvider
@maikschneider
Copy link
Owner Author

Released in new main branch. Version 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TYPO3 v12 compatibility
4 participants
@maikschneider @typoworx-de @Jeggle-s @moritz-ngo