tree: focus float nodes when switching workspaces #335
Conversation
|
This looks good in general. |
tadeokondrak
force-pushed
the
workspace-switch-focus-float-node
branch
from
a81e2d6 to
e1bbbb4
Compare
|
One thing I'm not sure about is if floating containers should be prioritized over tiling ones. Currently it's the floating containers but that feels motivated by the fact that there doesn't yet seem to be a way to focus them with the keyboard. |
|
I had only reviewed from my phone so far and hadn't caught that your change prioritizes floating windows over tiled ones. I'd prefer to only focus floating windows if all of the existing logic fails. As you say, the inability to navigate such windows with the keyboard alone exists independently workspace focus behavior. |
tadeokondrak
force-pushed
the
workspace-switch-focus-float-node
branch
from
e1bbbb4 to
834eedc
Compare
Sounds good, updated |
| } else if let Some(float) = self | ||
| .stacked | ||
| .rev_iter() | ||
| .find_map(|node| (*node).clone().node_into_float()) |
There was a problem hiding this comment.
This clone can be avoided but it doesn't allocate so I don't think it makes much of a difference
|
Thanks! |
Right now if a workspace only contains a floating node, switching to that workspace will not change the currently focused window (without focus-follows-mouse doing its thing)