Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up fix for PR744 #745
follow-up fix for PR744 #745
Changes from 21 commits
6565d7a
f817640
84bfeee
a173ead
6edaf63
1e3f522
8e865af
d9af1da
a3ff847
9e0c3bd
5eb9664
6cc883e
172f8c3
1f39058
3a4ddd8
77cb4d5
849c9a0
6069d07
9d89010
ad9bc11
01af64c
3888668
6642735
3bb99fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure, whether we'd come up with a final decision on this, but I thought that it is now in the responsibility of the people taking care of the respective projects to keep the project-specific scenario_configs up to date. Similar as with the project related start scripts?
Maybe we could have a dedicated discussion on this again in the MAgPIE meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up. Let's discuss about this in the MAgPIE meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FSEC scenario config maybe a separate case, or maybe even not (see comment above). One idea of splitting the project specific settings from the main scenario_config was that for general developments only the main scenario_config must be updated and thereby taking away the burden of also maintaining project-specific ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use FSEC in our default test runs, it should be updated from my view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not
vm_land.l
? I thought this was one of the points of PR before to have here same accuracy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turned out that vm_land.l and pcm_land differ considerably.
It seems that vm_land.l is not updated in all realizations.
This file was deleted.