Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for rds_report.R output script: fix units in "report.rds" file #740

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Oct 31, 2024

🐦 Description of this PR 🐦

With the most up-to-date R packages, units in report.rds are missing.
Therefore, results don't show up in shinyresults::appResults()
I guess the problem comes from as.quitte(report) and might be related to the use $ signs in our reporting.
The file report.mif seems fine.
Reading this file again after writing solves the problem.
I'm sure that there is a better solution than this hotfix but we need to be able to look at our results.
@pascal-sauer It would be great if you could have a look into this.

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

@flohump flohump marked this pull request as ready for review October 31, 2024 09:24
@emolinab
Copy link
Contributor

emolinab commented Nov 1, 2024

Thanks, Florian, for the fix! Do you have an example of a working shinyapp output after the fixes?

@pascal-sauer pascal-sauer merged commit dd71fec into magpiemodel:develop Nov 1, 2024
1 check passed
@flohump flohump deleted the f_fixreport branch November 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants