-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GDP to 2017 base year #717
Conversation
# Conflicts: # CHANGELOG.md # config/default.cfg # modules/29_cropland/detail_apr24/input.gms # modules/58_peatland/v2/declarations.gms # modules/58_peatland/v2/input.gms
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just three smaller comments
There are still quite a few places left where we have just USD and not USD17, you can find those on the cluster with |
Thanks for going through the whole magpie codebase to adapt to USD17! |
Co-authored-by: Debbora Leip <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
food demand module seems fine.
In residues module, the link to the datasource is broken, I suggested a new one.
Cost calculations seem a bit off.
More generally, its unclear how the switch from 05 to 17 was done for values in additional data or hardcoded values. In my opinion, they should be inflated.
All issues have been resolved based on bilateral discussion
🐦 Description of this PR 🐦
🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
Red = Develop from Aug 2024
Green = ThisPR with update to USD17MER
SSP2-Ref
SSP2-PkBud650
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly