-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add output report to validate spatial patterns in EU countries #680
Merged
DavidhoPIK
merged 8 commits into
magpiemodel:develop
from
DavidhoPIK:add_EU_output_report
Jun 21, 2024
Merged
add output report to validate spatial patterns in EU countries #680
DavidhoPIK
merged 8 commits into
magpiemodel:develop
from
DavidhoPIK:add_EU_output_report
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidhoPIK
changed the title
Add eu output report
Add output report for spatial patterns in the EU
May 27, 2024
DavidhoPIK
changed the title
Add output report for spatial patterns in the EU
add output report for spatial patterns of EU regions
May 27, 2024
DavidhoPIK
changed the title
add output report for spatial patterns of EU regions
add output report to validate spatial patterns in EU countries
May 27, 2024
jdrtommey
reviewed
Jun 7, 2024
jdrtommey
approved these changes
Jun 19, 2024
mishkos
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good.
DavidhoPIK
force-pushed
the
add_EU_output_report
branch
from
June 21, 2024 08:55
0f38159
to
773ace4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐦 Description of this PR 🐦
This PR adds an output report to validate EU spatial pattern against LUH2v2 data. It uses rmarkdown to output an interactive html document.
See some screenshots of an example output here:
and a full example output here.
(sometimes a reload after a minute or so is required on my PC for correct display of content)
🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly