New forest recovery based on potential forest area #676

pvjeetze · 2024-05-17T12:42:58Z

🐦 Description of this PR 🐦

Up to now, we used the average carbon density per cluster to determine whether other land would transform into secdforest over time. Also forestry could be expanded in all clusters, regardless of the forest potential and carbon density.

With this PR, forest expansion is only constrained to 0.5° grid cells with a carbon density of >20t/ha (which creates an area per cluster that can be used for forest expansion). This also means that carbon densities for forest are not anymore calculated based on all grid cells of a cluster but only consider cells where forest can potentially grow.

The forest potential is derived from LPJmL data and can therefore change across different RCPs.

🔧 Checklist for PR creator 🔧

Label pull request from the label list.
- Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
- Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
- High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
Self-review own code
- No hard coded numbers and cluster/country/region names.
- The new code doesn't contain declared but unused parameters or variables.
- magpie4 R library has been updated accordingly and backwards compatible where necessary.
- scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
Document changes
- Add changes to CHANGELOG.md
- Where relevant, put In-code documentation comments
- Properly address updates in interfaces in the module documentations
- run goxygen::goxygen() and verify the modified code is properly documented
Perform test runs
- Low risk:
  - Run a compilation check via Rscript start.R --> "compilation check"
- Medium risk:
  - Run test runs via Rscript start.R --> "test runs"
  - Check logs for errors/warnings
- High risk:
  - Run test runs via Rscript start.R --> "test runs"
  - Check logs for errors/warnings
  - Default run from the PR target branch for comparison
  - Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

Current develop branch default : ** mins
This PR's default : ** mins

🚨 Checklist for reviewer 🚨

PR is labeled correctly
Code changes look reasonable
- No hard coded numbers and cluster/country/region names.
- No unnecessary increase in module interfaces
- model behavior/performance is satisfactory.
Changes are properly documented
- CHANGELOG is updated correctly
- Updates in interfaces have been properly addressed in the module documentations
- In-code documentation looks appropriate
content review done (at least 1)
RSE review done (at least 1)

…f_newPotForest

into f_pForest

weindl

Many thanks for this development!

tscheypidi

changes look good to me and a quick check in shinyresults suggested to me that the new implementation might be even slightly faster. Nice work!

flohump

Looks very good overall. Thanks for these improvements.
I left some minor comments, mostly for clarification.
Do your test runs including the forestry sector?
It would be important to check if the new constraint for forest/forestry area expansion has major implications on plantation establishment.

flohump · 2024-05-23T05:58:21Z

modules/35_natveg/pot_forest_may24/equations.gms


 q35_carbon_other(j2,ag_pools,stockType) ..
    vm_carbon_stock(j2,"other",ag_pools,stockType) =e=
-      m_carbon_stock_ac(v35_other,pm_carbon_density_ac,"ac","ac_sub");
+      m_carbon_stock_ac(v35_other,pm_carbon_density_other_ac,"ac","ac_sub")
+    + m_carbon_stock_ac(v35_youngsecdf,pm_carbon_density_secdforest_ac,"ac","ac_sub");

 *' The biodiversity value (BV) of primary forest, secondary forest and other land is computed by multiplying their respective land area with bii coefficients, which depend on the age class and whether the potential natural vegetation forest or non-forest (luh2 side layers).



in the constraint q35_min_forest(j2) further below you can make use of the new set land_forest

thanks for spotting this. Changed the equation accordingly!

flohump · 2024-05-23T06:13:57Z

modules/80_optimization/nlp_apr17/solve.gms

@@ -47,25 +47,25 @@ if (magpie.modelstat > 2,
    if(s80_resolve_option = 1,
      display "Modelstat > 2 | Retry solve with CONOPT4 default setting";
      option nlp = conopt4;
-      magpie.optfile = 0;         
-    elseif s80_resolve_option = 2, 
+      magpie.optfile = 0;


This file seems content-wise unchanged. Only formatting has changed. Consider reverting.
For future work it would be good to find out why this happens and if it can be avoided.
It might be an inconsistency between editors used by different users
maybe @tscheypidi can help to sort this out for future work

My editor seems to remove trailing white spaces by default.

flohump · 2024-05-23T06:16:39Z

modules/35_natveg/pot_forest_may24/equations.gms

+*' the potential natural forest area minus the recovering secondary
+*' forest area.
+
+q35_max_forest_establishment(j2)..


This is the core constraint of the new imlementation, which also includes "forestry", i.e. plant, aff and npi.
Consider adding this detail in the above comment to make it clear that not only land in 35_natveg but also land in 32_forestry is affected by this constraint.

flohump · 2024-05-23T08:52:26Z

modules/35_natveg/pot_forest_may24/declarations.gms

 pc35_other(j,ac)                                 Other land per age class in current time step (mio. ha)
 p35_min_forest(t,j)                              Minimum forest and other stock based on NPI or NDC targets (mio. ha)
 p35_min_other(t,j)                               Minimum forest and other stock based on NPI or NDC targets (mio. ha)
 p35_damage_fader(t_all)                          Fader for forest damage (1)
+ p35_forest_recovery_shr(j)                       Forest share in natveg recovery (1)
 p35_recovered_forest(t,j,ac)                     Recovered forest (mio. ha)


Please remove if no longer needed.

p35_recovered_forest is still used to separated what goes into v35_other and v35_youngsecdf

tom remove any ambiguity in the reporting ,p35_recovered_forest is now renamed to p35_forest_recovery_area.

flohump

GAMS code looks good.
magpie4 R library still needs to be updated.

…le 32 to facilitate reporting

pvjeetze added 24 commits April 25, 2024 16:47

new forest recovery based on potential forest area

dd0cc68

new forest recovery based on potential forest area

3d69a6b

Merge branch 'develop' of https://github.com/magpiemodel/magpie into …

60c6343

…f_newPotForest

adjusted p35_forest_min

02d5cf5

max forest restoration fixes

364f7ab

bugfix

952c15c

fixes for forest damage and regeneration

77cba28

removed ndc forestry conflict

55a8125

use carbon density of other land where forest potential is zero

fcc0f4a

new realisation name

21fedf2

reworked forest regeneration

fd50ef4

fixes

ff4ec9a

land_agfo set not needed

ab85d32

reworked forest recovery equations

1942a8f

separated forest establishment and secondary forest recovery equations

79d9e72

minor adjustment

d69aa50

further adjustments

0eeddcb

resovled merge conflicts

0e1cbb4

resovled merge conflicts

7ff33c0

Merge branch 'f_WDPABaselineSplit' of https://github.com/pvjeetze/magpie

ebc6ad5

into f_pForest

reworked 35_natveg presolve regarding potential forest area

1e79ca8

separate carbon densities for forest and other land

6913e0f

reverted renaming of forestry and natveg module

e590de8

resolved merge conflict

93b6228

pvjeetze requested review from flohump, tscheypidi, weindl and FelicitasBeier May 17, 2024 12:43

pvjeetze changed the title ~~New forest recovery based on potential forest areaF p forest~~ New forest recovery based on potential forest area May 17, 2024

rework of forest establishment potential

9b0df5f

pvjeetze added 4 commits May 17, 2024 18:08

bugfix

7395c9a

forest establishment bound fix

41250ca

slight renaming

2e28b4a

slight renaming

26acf5a

pvjeetze added High risk Higher risk enhancement New feature or request data update Major Substantial modifications labels May 22, 2024

pvjeetze added 2 commits May 22, 2024 14:57

resolved merge conflicts

19d74d5

changelog

625a369

weindl approved these changes May 22, 2024

View reviewed changes

typos

f7efd46

tscheypidi approved these changes May 22, 2024

View reviewed changes

flohump requested changes May 23, 2024

View reviewed changes

addressed review comments

5210068

flohump reviewed May 23, 2024

View reviewed changes

pvjeetze added 2 commits May 23, 2024 11:55

minor streamlining of code

390afbd

reverted main.gms download paths

caa8ec0

pvjeetze requested a review from flohump May 23, 2024 11:31

pvjeetze added 4 commits May 23, 2024 16:35

carbon density fix

9e5ffd1

added interface vm_land_other to facilitate emissions calculations

9580188

not used fix

a48cf60

other land bound fix

8c8ee29

flohump approved these changes May 24, 2024

View reviewed changes

pvjeetze added 4 commits May 27, 2024 10:26

reodered dimensions of new parameters and variables in line with modu…

1cfad9d

…le 32 to facilitate reporting

redefined p35_forest_recovery_area to improve reporting

43d3496

parameter not needed

74fd1a8

max forest recovery fix

b846b24

pvjeetze merged commit 58cc585 into magpiemodel:develop May 28, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New forest recovery based on potential forest area #676

New forest recovery based on potential forest area #676

pvjeetze commented May 17, 2024 •

edited by tscheypidi

Loading

weindl left a comment

tscheypidi left a comment

flohump left a comment

flohump May 23, 2024

pvjeetze May 23, 2024 •

edited

Loading

flohump May 23, 2024

pvjeetze May 23, 2024

flohump May 23, 2024

pvjeetze May 23, 2024

flohump May 23, 2024

pvjeetze May 23, 2024

pvjeetze May 27, 2024

flohump left a comment

New forest recovery based on potential forest area #676

New forest recovery based on potential forest area #676

Conversation

pvjeetze commented May 17, 2024 • edited by tscheypidi Loading

🐦 Description of this PR 🐦

🔧 Checklist for PR creator 🔧

📉 Performance changes 📈

🚨 Checklist for reviewer 🚨

weindl left a comment

Choose a reason for hiding this comment

tscheypidi left a comment

Choose a reason for hiding this comment

flohump left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvjeetze May 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flohump left a comment

Choose a reason for hiding this comment

pvjeetze commented May 17, 2024 •

edited by tscheypidi

Loading

pvjeetze May 23, 2024 •

edited

Loading