Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgroForestry: treecover on cropland and betr #644
AgroForestry: treecover on cropland and betr #644
Changes from 8 commits
367222a
aecdaff
3ea3246
aa676cf
39738df
41cdffe
6725072
9c34926
f8c5e21
d2e21ce
afb8831
ed34c5e
531ffad
cc47972
9467984
20e42a2
f96fbb0
9b4b009
3845262
e7f8e40
3923e34
350667a
abdc8c8
67b57fc
495bf03
a0b0e15
43fd4fd
8333584
1014226
ec92cc6
876fc9d
8063487
a26ece2
3feb873
629a809
670e825
6b48d9e
eea0d5f
b44171c
abd5d8a
500c08f
4f4fbf4
c082921
5c455ed
34e0c6b
6279d34
274542d
a3eb576
34b830b
41d1deb
a179129
9d3b74a
960767e
5b89eee
0bdde4d
37a8b37
65f8202
560b736
a755ee5
b6fb489
c6c4756
f22f736
14eea42
a723bd9
f80ee75
ea597be
d0c8388
2143ba2
0b74f68
8d3df52
b406498
29ec05a
176fa1c
ccaf380
1745fcd
4d2b2e3
584aac5
6c23a00
444eaaf
d4f25ff
8e61949
518c25d
9d7befc
d8eb4e9
9f2acf4
f7125ac
46e2285
286d9c5
ac4c249
bc4c3cf
4ff9834
09535ff
4e94659
2f79c13
8fa3217
fdbbc1c
47256b8
ce923a3
3747457
b4a596d
9e175b4
72ce77e
2ce5f4b
7be483e
1d7b333
574f54d
95c0f43
893cbfd
d1ca47d
2c61aa6
02af343
be4d767
40b7ddf
a11c5ea
2beac3f
47b3982
404be5c
f9be6ac
f56a0c1
85e6fe5
dce8e0d
6119e52
442a7ab
a9904f0
1774fcf
cb0294f
604baa6
07b187b
6496d8f
b42d809
58d5ef8
6db3dcb
1d64e11
4b703be
560138b
4ac78c6
1050681
7c47023
d789ea6
e807eb5
6f55c1d
2924193
25cbd4f
96b833e
38d34ea
57638fc
8334590
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these files be read in in module 29_cropland?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting. removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? - than this should be rather tackled than bugfixes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to this PR. I just moved the code from preloop to input.gms.
I fully agree that the problem should be adressed (if still persistent) but in a different stream of work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more consistent to compute the treecover share in the agroforestry module. I think the existing interface pcm_land could be used for it (instead of making f10_land a new interface).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the historic numbers for 2015.
pcm_land
is the model outcome. Alternatively, we could add a time dimension topm_land_start
(currently on 1995)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens here and why? A new set but no other changes in the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from 32_forestry module.
This fits better into the ageclass module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is now fallow coming in here? this will change the default behavior of the realization, right? If so, it should be also labelled differently I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vm_fallow
is fixed to zero in this realization. Therefore, it will not change the default. I added it only for consistency with the other realizations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the resulting documenation. I would at least use full sentences to describe the methodology. The documentation page should read as a real documentation of the realization