-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfixes ac_est #624
bugfixes ac_est #624
Changes from 5 commits
f7dce1e
24b22c4
0800985
ca7be92
94a5319
1b6d0df
4224f7b
8910022
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,24 +73,24 @@ | |
*' This information is then passed to the land module ([10_land]): | ||
|
||
q35_landdiff .. vm_landdiff_natveg =e= | ||
sum((j2,ac), | ||
v35_other_expansion(j2,ac) | ||
+ v35_other_reduction(j2,ac) | ||
+ v35_secdforest_expansion(j2,ac) | ||
+ v35_secdforest_reduction(j2,ac) | ||
sum(j2, | ||
v35_other_expansion(j2) | ||
+ sum(ac_sub, v35_other_reduction(j2,ac_sub)) | ||
+ v35_secdforest_expansion(j2) | ||
+ sum(ac_sub, v35_secdforest_reduction(j2,ac_sub)) | ||
+ v35_primforest_reduction(j2)); | ||
|
||
q35_other_expansion(j2,ac_est) .. | ||
v35_other_expansion(j2,ac_est) =e= | ||
v35_other(j2,ac_est) - pc35_other(j2,ac_est); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To me it's not clear, why it is no longer necessary to subtract pc35_other here. Is the pc35_other parameter still used somewhere or not necessary anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And I have the same question for: q32_land_expansion(j2,type32) and q35_secdforest_expansion(j2,ac_est) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pc35_other(j2,ac_est) is always zero because other land added in the previous time step has been shifted to higher age-classes in-between the iterations. The same holds true for q32_land_expansion and q35_secdforest_expansion. pc35_other(j2,ac_sub) is the other part of the full ac set, which in the optimization can only decrease. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In that case, should the name of the variables and equations change to something pointing towards "aggregated forestry land pools"? The expansion part is confusing (or is the naming related to specific jargon used in the forestry field?). I thought pc32_land and pc35_other were related to the information from the previous step. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To which variables and equations are you referring regarding the naming? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I refer to q32_land_expansion(j2,type32), q35_secdforest_expansion(j2,ac_est), v35_other_expansion(j2,ac_est), and v32_land_expansion(j2,ac_est). So, is the difference between the previous and current steps (expansion) handled with the ac_sub dynamic set? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. In the optimization, expansion can only happen in |
||
q35_other_expansion(j2) .. | ||
v35_other_expansion(j2) =e= | ||
sum(ac_est, v35_other(j2,ac_est)); | ||
|
||
q35_other_reduction(j2,ac_sub) .. | ||
v35_other_reduction(j2,ac_sub) =e= | ||
pc35_other(j2,ac_sub) - v35_other(j2,ac_sub); | ||
|
||
q35_secdforest_expansion(j2,ac_est) .. | ||
v35_secdforest_expansion(j2,ac_est) =e= | ||
v35_secdforest(j2,ac_est) - pc35_secdforest(j2,ac_est); | ||
q35_secdforest_expansion(j2) .. | ||
v35_secdforest_expansion(j2) =e= | ||
sum(ac_est, v35_secdforest(j2,ac_est)); | ||
|
||
q35_secdforest_reduction(j2,ac_sub) .. | ||
v35_secdforest_reduction(j2,ac_sub) =e= | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,9 @@ | |
*** | MAgPIE License Exception, version 1.0 (see LICENSE file). | ||
*** | Contact: [email protected] | ||
|
||
v35_other_expansion.scale(j,ac) = 10e-3; | ||
v35_other_expansion.scale(j) = 10e-3; | ||
v35_other_reduction.scale(j,ac) = 10e-3; | ||
v35_secdforest_expansion.scale(j,ac) = 10e-3; | ||
v35_secdforest_expansion.scale(j) = 10e-3; | ||
v35_secdforest_reduction.scale(j,ac) = 10e-3; | ||
v35_hvarea_other.scale(j,ac) = 10e-3; | ||
vm_cost_hvarea_natveg.scale(i)$(s35_hvarea = 1 OR s35_hvarea = 2) = 10e4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure: the pc32_lanc(j2,type32,ac_est) is no longer needed in q32_land_expansion, but in q32_land_reduction it still enters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. But ac_est and ac_sub are dynamic sets of ac, depending on the time step length. It is not possible to define parameters, variables and equations for dynamics sets. Therefore, pc32_land is defined over ac.