Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact form #22

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add contact form #22

merged 1 commit into from
Jul 28, 2022

Conversation

GoogolGenius
Copy link
Member

@GoogolGenius GoogolGenius commented Jul 28, 2022 •
edited
Loading

Partially closes but not yet #20
Closes #23

@Ascent817 One problem with the modal is that there's no outer margin/padding at smaller screen widths due to how the dialog element works.

Screenshots:

image
image
image

@GoogolGenius GoogolGenius added the enhancement New feature or request label Jul 28, 2022
@GoogolGenius GoogolGenius requested a review from Ascent817 July 28, 2022 19:47
@GoogolGenius GoogolGenius enabled auto-merge (squash) July 28, 2022 19:48
Ascent817
Ascent817 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@Ascent817 Ascent817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm not sure about all the code you commented out. Might be better to remove the commented code altogether.

@GoogolGenius GoogolGenius merged commit 0d63d65 into main Jul 28, 2022
@GoogolGenius GoogolGenius deleted the feature/contact-form branch July 28, 2022 19:55
@GoogolGenius GoogolGenius mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ascent817 Ascent817 Ascent817 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contact form
2 participants
@GoogolGenius @Ascent817