- Update. #581
Merged
- Update. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieugh
requested changes
Oct 17, 2023
| this.logHandler.debug("CLOUDFORMATION CLIENT - Getting stack information", {stackName}, AwsModuleKeyname); | ||
| const command = new DescribeStacksCommand({ | ||
| StackName: stackName, | ||
| }) | ||
| try { | ||
| const response: DescribeStacksCommandOutput = await this.getClient().send(command); | ||
| if(!response.Stacks || response.Stacks.length < 1){ | ||
| throw new Error("No stacks were returned from cloudformation"); | ||
| return undefined; |
There was a problem hiding this comment.
I think maybe we should log a warning here as well ?
There was a problem hiding this comment.
No because it's the only way to know if a stack already exists, it's to query it.
| /** | ||
| * Gets the description and all its details from all the CloudFormation stacks. | ||
| */ | ||
| async listStacks(): Promise<Stack[] | undefined> { |
There was a problem hiding this comment.
Can this command really return undefined or just an empty array ?
There was a problem hiding this comment.
Apparently undefined but you are right I prefer an empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.