Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Move lockfile to cli crate #223

Merged
merged 1 commit into from
Apr 22, 2024
Merged

cargo: Move lockfile to cli crate #223

merged 1 commit into from
Apr 22, 2024

Conversation

felinira
Copy link
Collaborator

This removes the requirement for updating the magic-wormhole-rs crate on crates.io for library security issues in patch dependencies.

This removes the requirement for updating the magic-wormhole-rs crate on
crates.io for library security issues in patch dependencies.
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.34%. Comparing base (c511b45) to head (4770d8c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   39.38%   39.34%   -0.05%     
==========================================
  Files          18       18              
  Lines        3095     3088       -7     
==========================================
- Hits         1219     1215       -4     
+ Misses       1876     1873       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinira felinira merged commit b733cba into master Apr 22, 2024
11 of 14 checks passed
@felinira felinira deleted the fina/move-lockfile branch April 22, 2024 18:44
@felinira
Copy link
Collaborator Author

I had to revert this because it doesn't actually make sense what I was saying:

  • Cargo ignores lockfiles of dependencies
  • Cargo workspaces can only have a lockfile in the root directory, other lockfiles mostly get ignored for dependency resolution

I'll make a mental note that the lockfile in the workspace root does not actually mean anything.

https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control

However, this determinism can give a false sense of security because Cargo.lock does not affect the consumers of your package, only Cargo.toml does that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants