Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Update to clap 4 #218

Merged
merged 7 commits into from
Jul 6, 2024
Merged

cli: Update to clap 4 #218

merged 7 commits into from
Jul 6, 2024

Conversation

felinira
Copy link
Collaborator

  • Adds cli integration tests to spot any regressions in help as recommended in the clap migration guide
  • Updates to clap 4
  • Tweak the arguments to make the output look reasonable
  • Remove deprecations

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.19%. Comparing base (9e53e6e) to head (0e21a04).

Files Patch % Lines
src/transfer/v2.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   38.04%   38.19%   +0.15%     
==========================================
  Files          17       17              
  Lines        3144     3142       -2     
==========================================
+ Hits         1196     1200       +4     
+ Misses       1948     1942       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felinira felinira force-pushed the clap-4 branch 2 times, most recently from 3e5861c to 523037e Compare July 5, 2024 13:51
@felinira felinira merged commit 00c3ef9 into master Jul 6, 2024
18 checks passed
@felinira felinira deleted the clap-4 branch July 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant