Updating python libraries #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsuta
approved these changes
Aug 5, 2023
| import redis | ||
| from redis import Sentinel | ||
|
|
||
| class RedisSession(Session): |
There was a problem hiding this comment.
... should I use this when I integrate redis with Uber to store global session vars?
There was a problem hiding this comment.
You can probably just use the redis library directly. In this case I ended up just inlining the cherrys package (Which previously we installed) since it's all of ~100 lines and we needed some changes.
kitsuta
approved these changes
Mar 15, 2024
| @@ -176,7 +176,7 @@ def _ws_url(host, rpc_opts): | |||
| Given a hostname and set of config options returned by _rpc_opts, return the | |||
| standard URL websocket endpoint for a Sideboard remote service. | |||
| """ | |||
| return '{protocol}://{host}/wsrpc'.format(host=host, protocol='wss' if rpc_opts['ca'] else 'ws') | |||
| return '{protocol}://{host}/ws'.format(host=host, protocol='wss' if rpc_opts['ca'] else 'ws') | |||
There was a problem hiding this comment.
Will this break any third-party apps?
sideboard/server.py
Outdated
| raise cherrypy.HTTPError(401, 'not logged in') | ||
|
|
||
|
|
||
| @render_with_templates(config['template_dir']) |
There was a problem hiding this comment.
Is this all being ripped out or just moved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all python libraries to their latest versions.