LC2LT #324
Open
LC2LT #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariuszJozwiak
force-pushed
the
dev-LC2LT-flat
branch
from
c448536
to
951c033
Compare
Szpadel
requested changes
Jan 26, 2023
MariuszJozwiak
force-pushed
the
dev-LC2LT-flat
branch
from
e46c3ef
to
a3b8126
Compare
Szpadel
approved these changes
Jan 26, 2023
|
I will test it before merging |
Szpadel
requested changes
Jan 31, 2023
Szpadel
requested changes
Feb 1, 2023
site.maintenance.aws-remove-all.yml
Outdated
| shell: | | ||
| aws ec2 describe-launch-templates \ | ||
| --region '{{ aws_region }}' \ | ||
| --filter "Name=tag:Project,Values={{ mageops_project }}" --filter "Name=tag:Environment,Values={{ mageops_environment }}" |
There was a problem hiding this comment.
Filter using all tags, in the same way like it's done in roles/cs.aws-ec2-cleanup/tasks/main.yml
site.maintenance.aws-remove-all.yml
Outdated
|
|
||
| roles: | ||
| - role: cs.aws-ec2-cleanup |
site.maintenance.aws-remove-all.yml
Outdated
| @@ -144,6 +151,8 @@ | |||
| eni_id: "{{ item }}" | |||
| force_detach: true | |||
| with_items: "{{ _aws_eni_to_remove }}" | |||
| ignore_errors: true | |||
There was a problem hiding this comment.
we should not ignore errors here,
this is failing because aws does not allow manually managing network interfaces for lambdas
https://aws.amazon.com/premiumsupport/knowledge-center/lambda-eni-find-delete/
This step should be removed as is not required anymore
|
userdata passing no longer works |
MariuszJozwiak
force-pushed
the
dev-LC2LT-flat
branch
3 times, most recently
from
1f02931
to
402641a
Compare
Szpadel
force-pushed
the
dev-LC2LT-flat
branch
2 times, most recently
from
f45cf22
to
c43c4bf
Compare
ec2_launch_template normally only support resource tags without possibility to tag launch template itselt this makes it much harder to manage them in fully automatic way without requiring very specific names This modification makes resource_tags and tags parameter to have different meaning (originally those are aliases) tags - those are tags that are assigned to Launch Template resource_tags - those are tags that are assigned to ec2 instances and ebs volumes
MariuszJozwiak
force-pushed
the
dev-LC2LT-flat
branch
from
0bce405
to
64b876e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2021 and 2022, AWS provided details on the timeline for the deprecation of Amazon EC2 Launch Configurations. In the 2022 communication, we announced that accounts created on or after April 1, 2023, would no longer be able to create launch configurations through the AWS Management console. That date has shifted and is now June 1, 2023. This means that new accounts created on or after June 1, 2023, will only be able to create launch configurations through our API, command line interface (CLI), CloudFormation (CFN), and Terraform. This is intended to ensure that automation scenarios that have yet to be migrated to use Launch Templates are not impacted.