Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping FormatMessage Component with <div> so that browser translate… #4355

Conversation

del15881
Copy link
Collaborator

…d DOM will not fail the js DOM Manipulation.

Description

Fixing the Login and Create Account issues faced during DOM manipulation when the store front is translated to other languages using Browser Translations.
There is also 1 more change that is needed which is at file path "packages/venia-ui/lib/components/MiniCart/miniCart.js".
This required change is already found in PR : #4318 .
Check Commit ID : bbd3fb3

Related Issue

Closes #PWA-3378
https://jira.corp.adobe.com/browse/PWA-3378

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…d DOM will not fail the js DOM Manipulation.
@del15881 del15881 added bug Something isn't working version: Minor This changeset includes functionality added in a backwards compatible manner. pkg:venia-ui labels Nov 21, 2024
@del15881 del15881 requested a review from glo82145 November 21, 2024 11:56
@del15881 del15881 self-assigned this Nov 21, 2024
@pwa-studio-bot
Copy link
Collaborator

Messages
📖

Associated JIRA tickets: PWA-3378.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 9b49d31

@glo42707
Copy link
Contributor

glo42707 commented Dec 5, 2024

closing since duplicate of 4318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants