Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gift card options bug #370

Closed
wants to merge 2 commits into from
Closed

gift card options bug #370

wants to merge 2 commits into from

Conversation

bricht
Copy link
Contributor

@bricht bricht commented Oct 8, 2020

Description (*)

Related Pull Requests

https://github.com/magento/saas-export/pull/143
https://github.com/magento/partners-magento2-infrastructure/pull/42

Fixed Issues (if relevant)

  1. Fixes [Bug] Add more data to Gift Card options #368

Questions or comments

Code Review Checklist (*)

See dataied checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatibile changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

-Added label and render_type to gift card option test
@bricht bricht changed the title Giftcard options gift card options bug Oct 12, 2020
@bricht
Copy link
Contributor Author

bricht commented Oct 12, 2020

@magento run all tests

-Suppresed excessive method length warning on test class data provider
@bricht
Copy link
Contributor Author

bricht commented Oct 12, 2020

@magento run Static Tests

@bricht
Copy link
Contributor Author

bricht commented Oct 13, 2020

@magento run all tests

@vgoncharenko
Copy link
Contributor

Thank you for your contributio.
Your PR was merged to internal private fork: https://github.com/magento-commerce/catalog-storefront-ce/pull/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add more data to Gift Card options
3 participants