Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add more data to Gift Card options #368

Open
magento-engcom-team opened this issue Oct 6, 2020 · 2 comments
Open

[Bug] Add more data to Gift Card options #368

magento-engcom-team opened this issue Oct 6, 2020 · 2 comments
Assignees

Comments

@magento-engcom-team
Copy link

magento-engcom-team commented Oct 6, 2020

To be able to distinguish different gift card options (like sender email, open amount, sender name....) need to provide more data for each option: label + render_type

https://github.com/magento/catalog-storefront/blob/develop/app/code/Magento/CatalogStorefront/Test/Api/Product/ProductOptions/GiftCardProductTest.php#L269:L282

 

Specify the following render type:

  • "email" for any "email" option like sender email
  • "giftcard_open_amount" for "open amount"
  • "text" for any other field

 

@magento-engcom-team
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-97

@m2-assistant
Copy link

m2-assistant bot commented Oct 6, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants