Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get registered event sinks list #29

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

gowrizrh
Copy link
Member

@gowrizrh gowrizrh commented Aug 7, 2024

This is an idea to be able to retrieve registered event sinks info from the notifier factory itself without having to rely on plugins.

image

@avstudnitz This could potentially be used in the AsyncEventsAdminUi and other modules as necessary

avstudnitz
avstudnitz previously approved these changes Aug 13, 2024
Copy link
Contributor

@avstudnitz avstudnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion. Nice little helper!

Service/AsyncEvent/NotifierFactoryInterface.php Outdated Show resolved Hide resolved
@gowrizrh
Copy link
Member Author

@Vinai ready for merge

@sprankhub
Copy link

@gowrizrh, we worked on the permissions now and I think you should now be able to merge yourself...?

@gowrizrh gowrizrh merged commit 99e40f1 into mage-os:4.x Sep 17, 2024
4 checks passed
@gowrizrh gowrizrh deleted the feature/registered-notifiers branch September 17, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants