feat: run setup:di:compile on push #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienwebdev
requested changes
Sep 7, 2023
|
This also needs a workflow that tests the behavior against the stable branch of the MageOS repo. |
damienwebdev
requested changes
Sep 8, 2023
| @@ -0,0 +1,60 @@ | |||
| name: "Magento compilation (setup:di:compile)" | |||
There was a problem hiding this comment.
We need a test of this action here: https://github.com/mage-os/github-actions/blob/main/.github/workflows/_internal-setup-di-compile.yaml
There was a problem hiding this comment.
@damienwebdev @Tjitse-E the target of this link doesn't exist anymore, what should we do here?
fballiano
reviewed
Dec 23, 2024
|
@Tjitse-E @damienwebdev can we merge this also if we don't have the workflow inside this PR? The workflow is here: mage-os/mageos-magento2#33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Run
php bin/magento setup:di:compileon pushes, only when files are pushed that can actually break compilation in Mage-OS (PHP, XML or composer changes).Example fail.
Does this PR introduce a breaking change?