Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional fields: default to null #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

derhuerst
Copy link

@derhuerst derhuerst commented Sep 14, 2020

Fixes #20. Closes #21.


On my slow computer (Node.js v14.9.0) with e24d84f:

JSON (baseline) encoding: x 460,411 ops/sec ±1.81% (595 runs sampled)
JSON (baseline) decoding: x 449,983 ops/sec ±0.57% (597 runs sampled)
JSON (baseline) encoding + decoding: x 221,873 ops/sec ±0.13% (598 runs sampled)
protocol-buffers encoding: x 734,263 ops/sec ±0.61% (597 runs sampled)
protocol-buffers decoding: x 1,132,320 ops/sec ±0.12% (596 runs sampled)
protocol-buffers encoding + decoding: x 391,797 ops/sec ±0.08% (597 runs sampled)

without e24d84f:

JSON (baseline) encoding: x 499,192 ops/sec ±0.16% (597 runs sampled)
JSON (baseline) decoding: x 458,396 ops/sec ±0.11% (597 runs sampled)
JSON (baseline) encoding + decoding: x 225,796 ops/sec ±0.12% (597 runs sampled)
protocol-buffers encoding: x 727,112 ops/sec ±0.08% (597 runs sampled)
protocol-buffers decoding: x 1,050,047 ops/sec ±0.21% (597 runs sampled)
protocol-buffers encoding + decoding: x 402,329 ops/sec ±0.07% (597 runs sampled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of default values
2 participants