Support localized cronjob scheduling with ambiguous and gap DateTime instances #133
Conversation
| cond do | ||
| ?a in options and ?l in options -> [:earlier, :later] | ||
| ?a in options -> [:earlier] | ||
| true -> [:later] |
There was a problem hiding this comment.
I believe we should have the option to not run at all in cases of ambiguity. How would that be expressed?
|
|
||
| def parse("@" <> identifier, _) do | ||
| def parse("@" <> identifier, _, _) do |
There was a problem hiding this comment.
I believe we also need to pass the ambiguity options to specials. For example most of them run at midnight. There's no guarantee that a TZ change does not happen over midnight.
| end | ||
|
|
||
| def resolve_potential_gap(%{std_offset: n}, candidate = %{std_offset: m}, amt, _) do | ||
| cond do |
There was a problem hiding this comment.
I think this needs a bit more detail since DST shifts are not guaranteed to be one hour.
For example, Lord Howe Island is UTC +10:30 / +11:00
|
We also need to add the ambiguity options into |
|
@shaolang I pushed addtional tests to the PR. I believe they should not fail. Can you check? |
| {"30 2 * * *", [], "Europe/Zurich", ~N[2024-03-31 01:00:01], ["2024-04-01T02:30:00+02:00"]}, | ||
|
|
||
| # Half Hour Shift | ||
| {"*/30", [:earlier], "Australia/Lord_Howe", ~N[2024-04-07 01:15:01], |
There was a problem hiding this comment.
This should actually fail; the cron expression expects the frequency to be "every 30 minute", so shift/4 ignores the ambiguity opt; same comment for the other half-hour shift cases. I'll remove these test cases if you have no objections; alternatively, I can update them to the expected values, though I don't see the value-add in keeping them.
| ["2024-10-27T02:30:00+01:00", "2024-10-28T02:30:00+01:00"]}, | ||
| {"30 2 * * *", [:earlier, :later], "Europe/Zurich", ~N[2024-10-27 01:00:01], | ||
| ["2024-10-27T02:30:00+02:00", "2024-10-27T02:30:00+01:00", "2024-10-28T02:30:00+01:00"]}, | ||
| {"30 2 * * *", [], "Europe/Zurich", ~N[2024-10-27 01:00:01], ["2024-10-28T02:30:00+01:00"]}, |
There was a problem hiding this comment.
I reckon it might be faster to ask you about this: the screenshot shows the unit to advance is :hour, instead of the expected :day. This cron expression is "at 2:30 daily", so advancement should be :day.
Any idea?
There was a problem hiding this comment.
@shaolang I think we fist have to be clear about the Crontab.DateChecker. The scheduler should find all dates efficiently for instances where the date checker evaluates to truthy.
I've replaced DateHelper.add/3 with DateHelper.shift/4 that:
:on_ambiguitysettings.CronExpressiongains 2 options:a: returns earlier time when calculated DateTime is ambiguous.l: returns later time when calculated DateTime is ambiguous.I didn't add the
boption to cover both 'cos specifyingalis clearer, imo.I've also replaced all
NaiveDateTime.add/3calls inSchedulerwithDateHelper.shift/4. AsDateHelper.shift/4is rigorously tested, I didn't add tests for the updatedScheduer.Closes #131.