Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TCNPlus consistent, create the right config format, deleting assertion #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

BiqianCheng
Copy link

  • Ignore the changes of num_batches, which is somehow included in this commit
  • Missing batch normalization in the FCNPlus json.file
  • Ignore the modification of rnn.json
  • ATTENTION starts from here In the src/models/get_model.py, the model name is selected to be "FCN" however it later refers to FCNPlus's configurations. To make this consistent, I request to change them all into FCNPlus.
  • #25 The right configure format has been corrected. Otherwise, it will run into the "all strings cannot be converted to the right type" error.
  • src/models/tsai/tsai/models/FCNPlus.py, the assertion doesn't make sense since layers=[128, 256, 128], kss=[7, 5, 3] in default. We will never be able to pass the assertion. I commented it out so it is possible to try the FCNPlus model and see its performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant