Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO2 pipelines and storage #228

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

CO2 pipelines and storage #228

wants to merge 9 commits into from

Conversation

bennettm
Copy link
Collaborator

@bennettm bennettm commented Mar 13, 2024

Description

This PR is for the spatially explicit CO2 Transport and Storage model.

Previous CO2 Pipelines have now been divided into two types: Trunk (inter-zonal pipeline) and Spur (zone - CO2 site).

For incorporating these changes into future models new data is required. We need to know the location and characteristics of the sites. We also need to know the distance between the centroid of a zone and the location of the CO2 site.

Fixes issue #

N/A

Type of change

CO2 Pipelines have been divided into two types.
Additional balancing equation incorporated. First balancing equation accounts that the CO2 captured at a zone is equal to the amount of CO2 flowing out of that zone through trunk and spur pipelines.

Second balancing equation accounts for the flow of CO2 on the spur pipelines is equal to the amount of CO2 flowing into a given CO2 storage site.

Lastly, there is a constraint which accounts that the flow of CO2 across all the spur pipelines connected to a given CO2 site does not exceed the maximum injection limit of that site.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run tests with my code to avoid compatibility issues
  • Any dependent changes have been merged and published in downstream modules

@bennettm bennettm assigned bennettm and unassigned bennettm Mar 13, 2024
@chakz chakz requested review from RuaridhMacd and dharik13 March 13, 2024 20:01
@RuaridhMacd RuaridhMacd deleted the branch develop March 18, 2024 18:52
@RuaridhMacd RuaridhMacd reopened this Mar 20, 2024
@RuaridhMacd
Copy link
Collaborator

RuaridhMacd commented Mar 20, 2024

Hi @chakz Please update a few things:

  • Rebase this branch on develop
  • Remove or revert the changes on:
    • DOLPHYN-dev.code-workspace
    • Project.toml
    • Dolphyn/Project.toml
    • Run.sh
    • test.err
    • test.out
  • Did you mean to change the docstrings for several functions to show UCommit::Int, Reserves::Int), instead of setup::Dict. e.g.: co2_storage_investment(EP::Model, inputs::Dict, UCommit::Int, Reserves::Int)
  • Similarly, I think you've changed some docstrings to have inputs_gen::Dict instead of inputs_capture::Dict.

les-g-a and others added 9 commits April 25, 2024 14:58
The documentation for co2 transmission and co2 injection has been updated
Documentation files pertaining to the writing of CO2 Files have been updated.
Additional files were deleted to setup for PR
Making required changes for eventual integration with develop branch
The docstrings for the CO2 Supply Chain were updated so that the method definition and what is declared in doc_raw are the same.
@bennettm bennettm force-pushed the UndergroundH2Storage branch 2 times, most recently from e13b63e to a583503 Compare April 25, 2024 20:46
@RuaridhMacd RuaridhMacd changed the title Underground h2 storage CO2 pipelines and storage May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants