-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CO2 pipelines and storage #228
Open
bennettm
wants to merge
9
commits into
develop
Choose a base branch
from
UndergroundH2Storage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @chakz Please update a few things:
|
The documentation for co2 transmission and co2 injection has been updated
Documentation files pertaining to the writing of CO2 Files have been updated.
Additional files were deleted to setup for PR
Making required changes for eventual integration with develop branch
The docstrings for the CO2 Supply Chain were updated so that the method definition and what is declared in doc_raw are the same.
bennettm
force-pushed
the
UndergroundH2Storage
branch
2 times, most recently
from
April 25, 2024 20:46
e13b63e
to
a583503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for the spatially explicit CO2 Transport and Storage model.
Previous CO2 Pipelines have now been divided into two types: Trunk (inter-zonal pipeline) and Spur (zone - CO2 site).
For incorporating these changes into future models new data is required. We need to know the location and characteristics of the sites. We also need to know the distance between the centroid of a zone and the location of the CO2 site.
Fixes issue #
N/A
Type of change
CO2 Pipelines have been divided into two types.
Additional balancing equation incorporated. First balancing equation accounts that the CO2 captured at a zone is equal to the amount of CO2 flowing out of that zone through trunk and spur pipelines.
Second balancing equation accounts for the flow of CO2 on the spur pipelines is equal to the amount of CO2 flowing into a given CO2 storage site.
Lastly, there is a constraint which accounts that the flow of CO2 across all the spur pipelines connected to a given CO2 site does not exceed the maximum injection limit of that site.
Checklist: