Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2: enable BMFF support #15389

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Jul 17, 2022

Description

Enable BMFF support, to improve functionality in dependent ports like darktable.

Thus far, upstream releases haven't enabled this by default, due to potential concerns related to patents. However, the topic has been thoroughly discussed and vetted, enough so that upstream has now enabled by default on Master.

Patent-related discussions: Exiv2/exiv2#1679

Tested on macOS Releases

  • Intel x86_64: 10.6 through Monterey
  • PPC: 10.5

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port exiv2.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port labels Jul 17, 2022
@mascguy mascguy removed the request for review from ryandesign July 17, 2022 17:15
@mascguy
Copy link
Member Author

mascguy commented Jul 17, 2022

@jmroot Added you as well, so that you can also review the patent-related discussion.

@mascguy
Copy link
Member Author

mascguy commented Jul 17, 2022

@evanmiller @barracuda156 Tested on 10.5 PPC as well, and looks good.

@barracuda156
Copy link
Contributor

barracuda156 commented Jul 17, 2022

@evanmiller @barracuda156 Tested on 10.5 PPC as well, and looks good.

I can check on 10.6.8 Rosetta, let me build cmake.

UPD. Yes, it builds fine.

@mascguy
Copy link
Member Author

mascguy commented Aug 6, 2022

@ryandesign and @jmroot, thoughts on this?

@mascguy
Copy link
Member Author

mascguy commented Aug 6, 2022

The key takeaway - from the final comment in the patent discussion - is as follows:

The first version of ISOBMFF was 2004 and the container format was first used by MPEG in the 1990s. So, even if a patent has been infringed, the holder's "ownership" has almost certainly expired.

Given that, I think we're safe.

@ryandesign ryandesign merged commit ab68bae into macports:master Aug 6, 2022
@mascguy mascguy deleted the mascguy-exiv2 branch August 8, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

4 participants