Book improvements #448
Open
Book improvements #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jeertmans thanks for taking the time to review it! |
jeertmans
reviewed
Dec 6, 2024
examples/string-interpolation.rs
Outdated
There was a problem hiding this comment.
Hi @fmorroni, can you also add this document to the example sections in Cargo.toml?
There was a problem hiding this comment.
Hi @jeertmans do you mean adding this lines?
[[example]]
name = "string-interpolation"
path = "examples/string-interpolation.rs"Because I'd already added them. If that's not it I'm not sure what you mean, could you clarify please?
Co-authored-by: Jérome Eertmans <[email protected]>
Co-authored-by: Jérome Eertmans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some improvements to the Logos book as discussed in issue #418.
I still need to check how the initial state is chosen from the generated DFA when using the debug feature.